Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SDK requirements from semconv to spec #3839

Open
jpkrohling opened this issue Jan 23, 2024 · 2 comments
Open

Move SDK requirements from semconv to spec #3839

jpkrohling opened this issue Jan 23, 2024 · 2 comments
Labels
spec:resource Related to the specification/resource directory triage:accepted:needs-sponsor Ready to be implemented, but does not yet have a specification sponsor

Comments

@jpkrohling
Copy link
Member

As part of open-telemetry/semantic-conventions#312, we defined a new service.instance.id attribute, which should be added to the spec to track its implementation by SDKs. It should also specify how it can be configured (env vars, file, ...).

In the process, other two attributes were identified as having to be moved as well:

  • service.name
  • telemetry.sdk group

This is related to this whole section: https://github.com/open-telemetry/semantic-conventions/tree/main/docs/resource#semantic-attributes-with-sdk-provided-default-value

@jpkrohling
Copy link
Member Author

To be clear: what needs to be "moved" is the statement that those attributes MUST be populated by the SDK.

@jpkrohling
Copy link
Member Author

Further comment about the service.instance.id: the spec needs to account for applications running in front of application servers like unicorn. A special value for the service.instance.id could be set by users (uuidv1?), telling the SDK that a stable UUID isn't desirable.

@reyang reyang added the [label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR label Jan 24, 2024
@austinlparker austinlparker added triage:accepted:needs-sponsor Ready to be implemented, but does not yet have a specification sponsor and removed [label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR labels Apr 30, 2024
@austinlparker austinlparker moved this to Spec - Accepted in 🔭 Main Backlog Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:resource Related to the specification/resource directory triage:accepted:needs-sponsor Ready to be implemented, but does not yet have a specification sponsor
Projects
Status: Spec - Accepted
Development

No branches or pull requests

4 participants