Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default aggregation should mention "Attributes" from instrument advisory #3790

Open
cijothomas opened this issue Dec 13, 2023 · 0 comments
Open
Labels
spec:metrics Related to the specification/metrics directory triage:accepted:needs-sponsor Ready to be implemented, but does not yet have a specification sponsor

Comments

@cijothomas
Copy link
Member

What are you trying to achieve?

The default aggregation is only referring to using the instrument advisory parameter for ExplicitBucketBoundaries, but it should also include the instrument advisory parameter for Attributes.

What did you expect to see?

In the absence of view, SDKs are expected to use the instrument advisory parameter "Attributes", and use them for aggregation. This information is currently mentioned, but somewhat hidden under Views section on "Stream configuration". But it should be specified in the default aggregation section.

Additional context.

Given the experimental nature of "Attributes", this might be non-trivial to add without some refactoring of the aggregation section.

@cijothomas cijothomas added the spec:metrics Related to the specification/metrics directory label Dec 13, 2023
@reyang reyang added the [label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR label Dec 20, 2023
@austinlparker austinlparker added the triage:accepted:needs-sponsor Ready to be implemented, but does not yet have a specification sponsor label Apr 30, 2024
@austinlparker austinlparker removed the [label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR label Apr 30, 2024
@austinlparker austinlparker moved this to Spec - Accepted in 🔭 Main Backlog Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:metrics Related to the specification/metrics directory triage:accepted:needs-sponsor Ready to be implemented, but does not yet have a specification sponsor
Projects
Status: Spec - Accepted
Development

No branches or pull requests

4 participants