Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define requirement levels for metrics and their meaning #3176

Open
arminru opened this issue Feb 3, 2023 · 2 comments
Open

Define requirement levels for metrics and their meaning #3176

arminru opened this issue Feb 3, 2023 · 2 comments
Assignees
@trask
Labels
area:semantic-conventions Related to semantic conventions [label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR spec:metrics Related to the specification/metrics directory

Comments

@arminru
Copy link
Member

arminru commented Feb 3, 2023

Similar to the definition for attribute requirement levels in https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/common/attribute-requirement-level.md, we should also define the requirement levels for metrics.

Once a definition is added, we should link to it from https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/semantic_conventions/http-metrics.md (added in #3158) and the other places.

Related
@arminru arminru added area:semantic-conventions Related to semantic conventions spec:metrics Related to the specification/metrics directory labels Feb 3, 2023
This was referenced Feb 3, 2023
Merged
Closed
@arminru arminru moved this to Blocker for stability in Spec: HTTP Semantic Conventions Feb 3, 2023
@trask trask moved this to Blockers for HTTP semconv stability in Semantic Conventions + Instrumentation Stability WG Feb 6, 2023
@reyang reyang added the [label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR label Feb 11, 2023
@trask trask assigned trask and unassigned yurishkuro Feb 17, 2023
@trask trask mentioned this issue Feb 21, 2023
Merged
@trask
Copy link
Member

trask commented Mar 1, 2023

@arminru what do you think is remaining for this issue? and do you think those things are stability blockers? thx!

@trask
Copy link
Member

trask commented Mar 6, 2023

removing as an HTTP semconv stability blocker, let me know if you think there are parts of this that should still be considered a semconv stability blocker, thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trask trask

Labels
area:semantic-conventions Related to semantic conventions [label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR spec:metrics Related to the specification/metrics directory
Projects
Semantic Conventions + Instrumentation Stability WG
Status: No status
Milestone
No milestone
Development

No branches or pull requests
4 participants
@trask @yurishkuro @arminru @reyang