Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify scope attributes for zipkin and jaeger exporters #2744

Open
jack-berg opened this issue Aug 19, 2022 · 1 comment
Open

Clarify scope attributes for zipkin and jaeger exporters #2744

jack-berg opened this issue Aug 19, 2022 · 1 comment
Assignees
Labels
spec:trace Related to the specification/trace directory triaged-accepted The issue is triaged and accepted by the OTel community, one can proceed with creating a PR proposal

Comments

@jack-berg
Copy link
Member

The OpenTelemetry Transformation to non-OTLP formats has the following to say about scope attributes:

Exporters to formats that don't have a concept that is equivalent to the Scope SHOULD record the attributes at the most suitable place in their corresponding format, typically at the Span, Metric or LogRecord equivalent.

The Zipkin and jaeger are in this category since they don't have the equivalent of scope attributes. However, they already have documents explicitly defining their respective transformations.

It seems like the general advice of recording scope attributes as record level attributes should apply to Zipkin and Jaeger, but it would be good to explicitly state this.

@jack-berg jack-berg added the spec:trace Related to the specification/trace directory label Aug 19, 2022
@pirgeo
Copy link
Member

pirgeo commented Aug 22, 2022

This also seems related to #2736. When moving attributes from the OTLP scope to the Span/Metric data point/Log record, there might be an overlap in attribute keys, and a clash-resolution strategy is required.

@rbailey7210 rbailey7210 added the triaged-accepted The issue is triaged and accepted by the OTel community, one can proceed with creating a PR proposal label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:trace Related to the specification/trace directory triaged-accepted The issue is triaged and accepted by the OTel community, one can proceed with creating a PR proposal
Projects
None yet
Development

No branches or pull requests

4 participants