Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop requiring non-reversible schemas to be new major versions #2680

Open
tigrannajaryan opened this issue Jul 19, 2022 · 0 comments
Open

Stop requiring non-reversible schemas to be new major versions #2680

tigrannajaryan opened this issue Jul 19, 2022 · 0 comments
Assignees
Labels
[label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR spec:miscellaneous For issues that don't match any other spec label

Comments

@tigrannajaryan
Copy link
Member

In schema file definition for rename_attributes transformation we have the following:

When the reverse transformation is not possible it is considered an incompatible change. In this case the MAJOR version number of the schema SHOULD be increased in the new version.

However, at the same time we require that the schema version must be equal to Otel spec version number:

The version number of the schema is the same as the specification version number which publishes the schema.

The combination of these 2 requirements is that any time there is a non-reversible change in rename_attributes section we must increase the major version number of the Otel spec, which obviously is wrong.

I believe we need to delete the requirement that non-reversible rename_attributes transformation requires a new major version number of the schema. We should live with the fact that some changes to semantic conventions are one-way only (from old to new version) and cannot be reversed.

Alternatively (or in addition) we could prohibit any transformations that are non-reversible. This is worth considering too.

@tigrannajaryan tigrannajaryan added the spec:miscellaneous For issues that don't match any other spec label label Jul 19, 2022
@rbailey7210 rbailey7210 added the [label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR label Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR spec:miscellaneous For issues that don't match any other spec label
Projects
None yet
Development

No branches or pull requests

3 participants