-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove baggage handling from metrics SDK for now #2160
Comments
+1 with the consideration of:
|
Just want to make two points:
Specifically, I think the View APIs allowing |
The APIs need Context anyways for exemplars so I don't see them going away with the removal of language about baggage in SDKs. Adding to views in the future should be additive and no problem, agree that this is important so hopefully it will give some time to dig more into. |
I'm trying to find a balance and I ended up with this proposal (which I brought up in the Oct. 29th, 2021 Maintainer's SIG meeting):
|
We decided in the last SiG meeting to be a little more aggressive and remove baggage-in-view support from the SDK specification. We'd like to take some time to investigate Baggage interaction w/ instrumentation libraries in both Trace + Metrics and see if this style configuration belongs in a different layer than the raw signal SDK. |
Reading through the spec in context of #2150 to check it vs Java.
I think there should be a higher level cross-signal discussion about baggage before adding it to any particular signal. Notably, in Java instrumentation we generate one
Attributes
and would expect baggage to be populated into this via instrumentation. It would still be ok if the SDK in addition provided a mechanism for this transformation but would be awkward in two places, and the UX doesn't seem fleshed out vs the usage of baggage in traces and logs. I'm worried about jumping the gun on this.The current restriction to synchronous instruments also seems to tie the behavior of the view to the usage within the API (the view doesn't really know if data comes from synchronous or not). This seems like an unexpected coupling.
Finally, it seems unclear what it means to get "extra dimensions" from
Baggage/Context
- baggage is clear, but context?The text was updated successfully, but these errors were encountered: