Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify data model details for ExponentialHistogram #1932

Closed
jmacd opened this issue Sep 16, 2021 · 1 comment · Fixed by #1935
Closed

Specify data model details for ExponentialHistogram #1932

jmacd opened this issue Sep 16, 2021 · 1 comment · Fixed by #1935
Assignees
@jmacd
Labels
area:data-model For issues related to data model spec:metrics Related to the specification/metrics directory

Comments

@jmacd
Copy link
Contributor

jmacd commented Sep 16, 2021

What are you trying to achieve?

The metrics protocol is about to add a new data point type, ExponentialHistogram. The protocol PR specified in open-telemetry/opentelemetry-proto#322 is able to express certain combinations of data that are unreasonable or have no practical use at this time and implementations are not expected to support all inputs. Details of this sort belong in the data model, not comments in the protocol definition.

See open-telemetry/opentelemetry-proto#322 (comment)
@jmacd jmacd added the spec:metrics Related to the specification/metrics directory label Sep 16, 2021
This was referenced Sep 16, 2021
Merged
Merged
Merged
@tigrannajaryan
Copy link
Member

@jmacd reassigning this to you since you are the expert.

@reyang reyang added the area:data-model For issues related to data model label Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmacd jmacd

Labels
area:data-model For issues related to data model spec:metrics Related to the specification/metrics directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ExponentialHistogram to Metrics data model jmacd/opentelemetry-specification
3 participants
@jmacd @tigrannajaryan @reyang