-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B3 Propagation Config #1562
Comments
@mwear I think in practice, there's basically no situation you'd need to only support a single format on extraction - that would mean getting different data in the two b3 headers which no instrumentation should be doing really. That's probably why we have the current spec and it seems reasonable to me. For I've never actually needed / wanted to use the method before, but looking at the javadoc it seems wrong Fields is more to help injection, not extraction, so I guess that Java needs to be fixed to return different Naturally it'd be good to add this to the spec. |
Isn't this OTel b3 the default? When you pick the b3 propagator, you get the otel flavor. Is this good enough? Just for clarity, what is the pain point right now? |
I think that sounds reasonable.
The spec currently says this: Known values for OTEL_PROPAGATORS are: I think we would need to clarify that |
We discussed this at the maintainers meeting this morning and the consensus is that we should always extract both b3 formats, and that the configuration should correspond to the inject format. We'll clarify this in the specification. |
There are essentially three ways to configure b3. The b3 spec defines b3 single and multi-header formats. OTel has its own flavor of b3 where single and multi-header formats should be extracted, but only single-header should be injected.
The environment variable specification only defines configuration for two of the three formats mentioned above. It defines
b3
as b3 single-header, andb3multi
as b3 multi-header, but does not provide a value for the OTel flavor. It might be too late to change this, but in a perfect world, I think the following values would make sense:b3
- OTel flavor b3b3multi
- multi-header b3b3single
- single-header b3Is this change possible or is there an alternative that we can consider?
The text was updated successfully, but these errors were encountered: