Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a new resource attribute for AWS Lambda function alias #1280

Closed
mateuszrzeszutek opened this issue Dec 9, 2020 · 4 comments · Fixed by #1781
Closed

Introduce a new resource attribute for AWS Lambda function alias #1280

mateuszrzeszutek opened this issue Dec 9, 2020 · 4 comments · Fixed by #1781
Labels
area:semantic-conventions Related to semantic conventions priority:p3 Lowest priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:resource Related to the specification/resource directory

Comments

@mateuszrzeszutek
Copy link
Member

What are you trying to achieve?

I propose adding a new optional resource attribute that will store the AWS Lambda function alias (if it's used at all), named aws.lambda.alias.

Additional context.

@mateuszrzeszutek mateuszrzeszutek added the spec:resource Related to the specification/resource directory label Dec 9, 2020
@thisthat
Copy link
Member

thisthat commented Dec 9, 2020

Currently, the alias is caught inside the faas.id attribute.
Do you think it would be better to remove the alias from the id attribute and report it inside aws.lambda.alias?

@Oberon00 Oberon00 added the area:semantic-conventions Related to semantic conventions label Dec 9, 2020
@Oberon00
Copy link
Member

Oberon00 commented Dec 9, 2020

I'm wondering about that: If a function has multiple aliases, would a request to one alias re-use an instance started by a request to another alias (or the un-aliased ARN)? If so, then we must not report the AWS alias in faas.id when used as resource attribute.

@Oberon00
Copy link
Member

Oberon00 commented Dec 9, 2020

Relatedly, #1265 allows faas.id as span attribute.

@mateuszrzeszutek
Copy link
Member Author

mateuszrzeszutek commented Dec 11, 2020

I'm wondering about that: If a function has multiple aliases, would a request to one alias re-use an instance started by a request to another alias (or the un-aliased ARN)?

That's a very good question. I don't know that -- I'll test it and come back here with the answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions priority:p3 Lowest priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:resource Related to the specification/resource directory
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants