Skip to content

Commit ac800f1

Browse files
Address PR comments
1 parent e229c97 commit ac800f1

File tree

3 files changed

+5
-11
lines changed

3 files changed

+5
-11
lines changed

CHANGELOG.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,10 @@ release.
99

1010
New:
1111

12-
<<<<<<< HEAD
1312
- Document service name mapping for Jaeger exporters
1413
([1222](https://github.com/open-telemetry/opentelemetry-specification/pull/1222))
15-
=======
1614
- Change default OTLP port number
1715
([#1221](https://github.com/open-telemetry/opentelemetry-specification/pull/1221))
18-
>>>>>>> Change default OTLP port number
1916
- Add performance benchmark specification
2017
([#748](https://github.com/open-telemetry/opentelemetry-specification/pull/748))
2118
- Enforce that the Baggage API must be fully functional, even without an installed SDK.

specification/protocol/exporter.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ The following configuration options MUST be available to configure the OTLP expo
88

99
| Configuration Option | Description | Default | Env variable |
1010
| -------------------- | ------------------------------------------------------------ | ----------------- | ------------------------------------------------------------ |
11-
| Endpoint | Target to which the exporter is going to send spans or metrics. This MAY be configured to include a path (e.g. `example.com/v1/traces`). | `localhost:55680` | `OTEL_EXPORTER_OTLP_ENDPOINT` `OTEL_EXPORTER_OTLP_SPAN_ENDPOINT` `OTEL_EXPORTER_OTLP_METRIC_ENDPOINT` |
11+
| Endpoint | Target to which the exporter is going to send spans or metrics. This MAY be configured to include a path (e.g. `example.com/v1/traces`). | `localhost:4317` | `OTEL_EXPORTER_OTLP_ENDPOINT` `OTEL_EXPORTER_OTLP_SPAN_ENDPOINT` `OTEL_EXPORTER_OTLP_METRIC_ENDPOINT` |
1212
| Protocol | The protocol used to transmit the data. One of `grpc`,`http/json`,`http/protobuf`. | `grpc` | `OTEL_EXPORTER_OTLP_PROTOCOL` `OTEL_EXPORTER_OTLP_SPAN_PROTOCOL` `OTEL_EXPORTER_OTLP_METRIC_PROTOCOL` |
1313
| Insecure | Whether to enable client transport security for the exporter's `grpc` or `http` connection. | `false` | `OTEL_EXPORTER_OTLP_INSECURE` `OTEL_EXPORTER_OTLP_SPAN_INSECURE` `OTEL_EXPORTER_OTLP_METRIC_INSECURE` |
1414
| Certificate File | Path to certificate file for TLS credentials of gRPC client. Should only be used if `insecure` is set to `false`. | n/a | `OTEL_EXPORTER_OTLP_CERTIFICATE` `OTEL_EXPORTER_OTLP_SPAN_CERTIFICATE` `OTEL_EXPORTER_OTLP_METRIC_CERTIFICATE` |
@@ -26,7 +26,7 @@ Example 1
2626
The following configuration sends all signals to the same collector:
2727

2828
```bash
29-
export OTEL_EXPORTER_OTLP_ENDPOINT=collector:55680
29+
export OTEL_EXPORTER_OTLP_ENDPOINT=collector:4317
3030
export OTEL_EXPORTER_OTLP_PROTOCOL=grpc
3131
```
3232

@@ -35,7 +35,7 @@ Example 2
3535
Traces and metrics are sent to different collectors using different protocols:
3636

3737
```bash
38-
export OTEL_EXPORTER_OTLP_SPAN_ENDPOINT=collector:55680
38+
export OTEL_EXPORTER_OTLP_SPAN_ENDPOINT=collector:4317
3939
export OTEL_EXPORTER_OTLP_SPAN_PROTOCOL=grpc
4040
export OTEL_EXPORTER_OTLP_SPAN_INSECURE=true
4141

@@ -48,7 +48,7 @@ Example 3
4848
Traces are configured using the generic configuration, metrics are configured using specific configuration:
4949

5050
```bash
51-
export OTEL_EXPORTER_OTLP_ENDPOINT=collector:55680
51+
export OTEL_EXPORTER_OTLP_ENDPOINT=collector:4317
5252
export OTEL_EXPORTER_OTLP_PROTOCOL=grpc
5353

5454
export OTEL_EXPORTER_OTLP_METRICS_ENDPOINT=collector.example.com/v1/metrics

specification/protocol/otlp.md

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -445,10 +445,7 @@ connections SHOULD be configurable.
445445

446446
#### Default Port
447447

448-
The default network port for OTLP/HTTP is 4318. There is currently an [open
449-
issue](https://github.com/open-telemetry/opentelemetry-collector/issues/1256) to
450-
use the same port for OTLP/gRPC and OTLP/HTTP. In that case this spec will be
451-
updated to use the same default port for OTLP/gRPC and OTLP/HTTP.
448+
The default network port for OTLP/HTTP is 4317.
452449

453450
## Implementation Recommendations
454451

0 commit comments

Comments
 (0)