From 9c6dfa22225f1bf8f68a7bcfc97286c3e407f58b Mon Sep 17 00:00:00 2001 From: David Ashpole Date: Thu, 18 Aug 2022 15:33:56 +0000 Subject: [PATCH] address feedback --- specification/metrics/data-model.md | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/specification/metrics/data-model.md b/specification/metrics/data-model.md index e62c1695c1e..9ea7f2cda5d 100644 --- a/specification/metrics/data-model.md +++ b/specification/metrics/data-model.md @@ -1297,10 +1297,10 @@ attribute. Additional labels MUST be added as scope attributes, with keys and values unaltered. Other metrics in the batch which have a prefix equal to the prefix of the `_opentelemetry_scope_info` metric have the matching prefix removed, and are placed within that Instrumentation Scope. For example, the -Prometheus metrics: +OpenMetrics metrics: ``` -# TYPE otelhttp_opentelemetry_scope_info gauge +# TYPE otelhttp_opentelemetry_scope_info info otelhttp_opentelemetry_scope_info{name="go.opentelemetry.io.contrib.instrumentation.net.http.otelhttp",version="v0.24.0",library_mascot="bear"} 1 # TYPE otelhttp_http_server_duration counter otelhttp_http_server_duration{...} 1 @@ -1392,12 +1392,12 @@ serves the same purpose. `_`, if present, MUST be attached as prefix to all metrics from an Instrumentation Scope. For each Instrumentation Scope with a `scope.short_name` attribute, Prometheus -exporters SHOULD generate an info-typed metric named -`_opentelemetry_scope_info`. If multiple Instrumentation Scopes have -the same `scope.short_name`, do not generate either metric. If present, -Instrumentation Scope `name` and `version` MUST be added as `name` and -`version` labels. Values for `name` and `version` labels, as well as -additional scope attributes (other than `scope.short_name`) MUST be added +exporters SHOULD generate an [Info](https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md#info)-typed +metric named `_opentelemetry_scope_info`. If multiple +Instrumentation Scopes within the batch of metrics being scraped have the same +`scope.short_name`, do not generate either metric. If present, Instrumentation +Scope `name` and `version` MUST be added as `name` and `version` labels. Values +for `name` and `version` labels, as well as additional scope attributes (other than `scope.short_name`) MUST be added following the rules described in the [`Metric Attributes`](#metric-attributes) section below.