Skip to content

Commit

Permalink
Reorder points on ID generation
Browse files Browse the repository at this point in the history
  • Loading branch information
NathanielRN committed Dec 15, 2020
1 parent b973639 commit 2581331
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion spec-compliance-matrix.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ status of the feature is not known.
|Allow samplers to modify tracestate | | + | | + | | + | | + | | | |
|ShouldSample gets full parent Context | | + | + | + | | + | | | | | |
|[New Span ID created also for non-recording Spans](specification/trace/sdk.md#sdk-span-creation) | | | | + | | | | | | | |
|SDK Trace & Span ID generation is customizable| | + | |+ | | | | | | + |
|SDK Trace & Span ID generation is customizable| | + | |+ | | | | | | + | |

## Baggage

Expand Down
6 changes: 3 additions & 3 deletions specification/trace/sdk.md
Original file line number Diff line number Diff line change
Expand Up @@ -222,12 +222,12 @@ Note: Implementation-wise, this could mean that `Tracer` instances have a
reference to their `TracerProvider` and access configuration only via this
reference.

The SDK MUST by default randomly generate the bytes for both the `TraceId` and
the `SpanId`.

The SDK MUST provide a mechanism for customizing the way IDs are generated for
both the `TraceId` and the `SpanId`.

The SDK SHOULD by default randomly generate the bytes for both the `TraceId` and
the `SpanId`.

The SDK MAY provide this functionality by allowing custom implementations of
an interface like `IdsGenerator` below, which provides extension points for two
methods, one to generate a `SpanID` and one to generate a `TraceId`.
Expand Down

0 comments on commit 2581331

Please sign in to comment.