-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Optimize cloning of Context since it is immutable #2861
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2861 +/- ##
=====================================
Coverage 81.1% 81.1%
=====================================
Files 124 124
Lines 23927 23961 +34
=====================================
+ Hits 19410 19441 +31
- Misses 4517 4520 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d79a782
to
dc038f9
Compare
👷 build bot output from this run:
|
dc038f9
to
06eb4a1
Compare
These are the benchmark numbers from this run: And yes, the suppression check is slower, but on the other hand context attach and cloning is way faster.
|
e3aca49
to
ad3ad40
Compare
This is still a draft until #2870 has been merged and all benchmarks are run properly. |
ad3ad40
to
9a9e5f6
Compare
Changes
This PR optimizes
Context
cloning and attach. It tries to mitigate the performance impact of #2821 on those operations.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes