-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make LogRecord fields private and add getters for encapsulation #2314
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2314 +/- ##
======================================
Coverage ? 79.4%
======================================
Files ? 122
Lines ? 21708
Branches ? 0
======================================
Hits ? 17255
Misses ? 4453
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with changelog as this is breaking export/processor authors.
updated changelog. |
Changes
The PR refactors the
LogRecord
struct by making all its fields crate-private for better abstraction. Public getter methods have been added to provide controlled access to the fields.TBD - Will add changelog, if the changes are agreed.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes