Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: OTEL_RESOURCE_ATTRIBUTES doesn't support some characters in the accepted range #2110

Open
wperron opened this issue Sep 12, 2024 · 2 comments · May be fixed by #2120
Open

[Bug]: OTEL_RESOURCE_ATTRIBUTES doesn't support some characters in the accepted range #2110

wperron opened this issue Sep 12, 2024 · 2 comments · May be fixed by #2120
Labels
bug Something isn't working triage:todo Needs to be traiged.

Comments

@wperron
Copy link
Contributor

wperron commented Sep 12, 2024

What happened?

Some characters in the W3C Baggage octet-range, namely the equal sign (=) breaks Resource initialization from env.

API Version

0.24

SDK Version

0.24

What Exporter(s) are you seeing the problem on?

N/A

Relevant log output

No response
@wperron wperron added bug Something isn't working triage:todo Needs to be traiged. labels Sep 12, 2024
@cijothomas
Copy link
Member

Can you elaborate? Resources are expected to support OTel Attributes. What part is it missing, so we can fix it

@wperron
Copy link
Contributor Author

wperron commented Sep 13, 2024 •
edited
Loading

Sure! If I pass something like a base64-encoded value (anything that ends with an equal sign really) with OTEL_RESOURCE_ATTRIBUTES, it simply doesn't get picked up by the Resource constructor. For example OTEL_RESOURCE_ATTRIBUTES='key=value='.

wperron added a commit to wperron/opentelemetry-rust that referenced this issue Sep 16, 2024
@wperron
Allow values containing '=' in OTEL_RESOURCE_ATTRIBUTES
2d61328 
Values passed in to `OTEL_RESOURCE_ATTRIBUTES` containing an equal sign
`"="` are currently ignored by the Resource constructor, but should be
accepted as it is part of the [W3C Baggage octet
range](https://www.w3.org/TR/baggage/#header-content).

Fixes open-telemetry#2110
@wperron wperron linked a pull request Sep 16, 2024 that will close this issue
Open
4 tasks
wperron added a commit to wperron/opentelemetry-rust that referenced this issue Sep 16, 2024
@wperron
Allow values containing '=' in OTEL_RESOURCE_ATTRIBUTES
0b5d2b5 
Values passed in to `OTEL_RESOURCE_ATTRIBUTES` containing an equal sign
`"="` are currently ignored by the Resource constructor, but should be
accepted as it is part of the [W3C Baggage octet
range](https://www.w3.org/TR/baggage/#header-content).

Fixes open-telemetry#2110
wperron added a commit to wperron/opentelemetry-rust that referenced this issue Sep 16, 2024
@wperron
Allow values containing '=' in OTEL_RESOURCE_ATTRIBUTES
1e469c4 
Values passed in to `OTEL_RESOURCE_ATTRIBUTES` containing an equal sign
`"="` are currently ignored by the Resource constructor, but should be
accepted as it is part of the [W3C Baggage octet
range](https://www.w3.org/TR/baggage/#header-content).

Fixes open-telemetry#2110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working triage:todo Needs to be traiged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow values containing '=' in OTEL_RESOURCE_ATTRIBUTES wperron/opentelemetry-rust
2 participants
@cijothomas @wperron