Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to tonic 0.12 and prost 0.13 for hyper 1.x #1916

Closed
tisonkun opened this issue Jul 8, 2024 · 3 comments
Closed

Upgrade to tonic 0.12 and prost 0.13 for hyper 1.x #1916

tisonkun opened this issue Jul 8, 2024 · 3 comments

Comments

@tisonkun
Copy link

tisonkun commented Jul 8, 2024

Hyper and HTTP reaches 1.x at the end of last year. Now tonic releases 0.12 to catch up this change and opentelemetry-rust could follow it.

@tisonkun tisonkun changed the title Upgrade to tonic 0.13 for hyper 1.x Upgrade to tonic 0.12 and prost 0.13 for hyper 1.x Jul 8, 2024
@tisonkun
Copy link
Author

tisonkun commented Jul 8, 2024

Some legacy structs are moved to hyper-utils and we should resolve it by add hyper-util into dependencies.

However, this conflict seems requiring specific care:

   --> opentelemetry-proto/src/proto/tonic/opentelemetry.proto.logs.v1.rs:197:68
    |
197 | #[derive(Clone, Copy, Debug, PartialEq, Eq, Hash, PartialOrd, Ord, ::prost::Enumeration)]
    |                                                                    ^^^^^^^^^^^^^^^^^^^^
    |
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
    = note: for more information, see issue #57644 <https://github.com/rust-lang/rust/issues/57644>
note: `Error` could refer to the variant defined here
   --> opentelemetry-proto/src/proto/tonic/opentelemetry.proto.logs.v1.rs:218:5
    |
218 |     Error = 17,
    |     ^^^^^
note: `Error` could also refer to the associated type defined here
   --> /Users/tison/.rustup/toolchains/nightly-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/convert/mod.rs:682:5
    |
682 |     type Error;
    |     ^^^^^^^^^^
    = note: `#[deny(ambiguous_associated_items)]` on by default
    = note: this error originates in the derive macro `::prost::Enumeration` (in Nightly builds, run with -Z macro-backtrace for more info)

@lalitb
Copy link
Member

lalitb commented Jul 8, 2024

I believe #1674 fixes it.

@tisonkun
Copy link
Author

tisonkun commented Jul 8, 2024

Thank you! Close as a duplicate of #1427.

@tisonkun tisonkun closed this as not planned Won't fix, can't repro, duplicate, stale Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants