Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing Impact of random generation on span creation. #1367

Open
hdost opened this issue Nov 12, 2023 · 0 comments
Open

Reducing Impact of random generation on span creation. #1367

hdost opened this issue Nov 12, 2023 · 0 comments

Comments

@hdost
Copy link
Contributor

hdost commented Nov 12, 2023

          > > > So i did a few tests looks like 2-7%. I'll post the full results when I'm back at my computer.

For the entropy, i like the idea, but the one question I have is will this sharing of the first 64 bits result in a skew in of sampling.

@shaun-cox any thoughts on this ?

I don't readily see any issues with sampling skew, but I'm not an expert. 64-bits of randomness in the trace id would seem to provide enough to make uniform sampling decisions.

I'll also reference this sdk issue which I came across while researching: open-telemetry/opentelemetry-specification#1413

open-telemetry/opentelemetry-specification#3411 Related.

Originally posted by @cijothomas in #1106 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant