From 75b325927004ccc9f1d0dbba5be98620a12ef000 Mon Sep 17 00:00:00 2001 From: Aumetra Weisman Date: Fri, 3 May 2024 16:47:04 +0200 Subject: [PATCH] Fix some lints --- opentelemetry-sdk/src/logs/log_emitter.rs | 2 +- opentelemetry-sdk/src/metrics/periodic_reader.rs | 2 +- opentelemetry-sdk/src/trace/span_processor.rs | 2 +- opentelemetry-zipkin/src/lib.rs | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/opentelemetry-sdk/src/logs/log_emitter.rs b/opentelemetry-sdk/src/logs/log_emitter.rs index 9914c7b408..faadf473b3 100644 --- a/opentelemetry-sdk/src/logs/log_emitter.rs +++ b/opentelemetry-sdk/src/logs/log_emitter.rs @@ -312,7 +312,7 @@ mod tests { use opentelemetry::{Key, KeyValue, Value}; use std::fmt::{Debug, Formatter}; use std::sync::atomic::AtomicU64; - use std::sync::{Arc, Mutex}; + use std::sync::Mutex; use std::thread; struct ShutdownTestLogProcessor { diff --git a/opentelemetry-sdk/src/metrics/periodic_reader.rs b/opentelemetry-sdk/src/metrics/periodic_reader.rs index 81df8d32f7..034053bdbc 100644 --- a/opentelemetry-sdk/src/metrics/periodic_reader.rs +++ b/opentelemetry-sdk/src/metrics/periodic_reader.rs @@ -291,7 +291,7 @@ impl PeriodicReaderWorker { true } - async fn run(mut self, mut messages: impl Unpin + FusedStream) { + async fn run(mut self, mut messages: impl FusedStream + Unpin) { while let Some(message) = messages.next().await { if !self.process_message(message).await { break; diff --git a/opentelemetry-sdk/src/trace/span_processor.rs b/opentelemetry-sdk/src/trace/span_processor.rs index 214c0e5768..b99dc45311 100644 --- a/opentelemetry-sdk/src/trace/span_processor.rs +++ b/opentelemetry-sdk/src/trace/span_processor.rs @@ -422,7 +422,7 @@ impl BatchSpanProcessorInternal { }) } - async fn run(mut self, mut messages: impl Unpin + FusedStream) { + async fn run(mut self, mut messages: impl FusedStream + Unpin) { loop { select! { // FuturesUnordered implements Fuse intelligently such that it diff --git a/opentelemetry-zipkin/src/lib.rs b/opentelemetry-zipkin/src/lib.rs index 29e898b130..d884ab740a 100644 --- a/opentelemetry-zipkin/src/lib.rs +++ b/opentelemetry-zipkin/src/lib.rs @@ -84,7 +84,7 @@ //! [`ZipkinPipelineBuilder`] docs for details of each option. //! //! -//! ```no_run,ignore +//! ```no_run //! use opentelemetry::{global, KeyValue, trace::Tracer}; //! use opentelemetry_sdk::{trace::{self, RandomIdGenerator, Sampler}, Resource}; //! use opentelemetry_sdk::export::trace::ExportResult;