You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't think we should change anything in our implementation, since the Ruby HTTP ecosystem really requires this distinction (almost?) everywhere. I'm just creating this issue to solicit and record agreement.
I agree it's useful to have http and text versions of the propagators readily available due to Rack. I'm wondering if we could "meet in the middle" by calling our TextInjector / Extractor a TextMapInjector / Extractor. We could keep the http and text distinction, but the types would line up with the spec. I'm also fine with keeping things as-is.
open-telemetry/opentelemetry-specification#793 renamed the
HttpTextPropagator
toTextMapPropagator
. We have a split in our implementation betweenhttp
andtext
propagationopentelemetry-ruby/api/lib/opentelemetry/context/propagation/propagation.rb
Lines 12 to 19 in 7a10db9
opentelemetry-ruby/sdk/lib/opentelemetry/sdk/configurator.rb
Lines 130 to 135 in 7a10db9
because we need to support Rack extractors for HTTP:
opentelemetry-ruby/sdk/lib/opentelemetry/sdk/configurator.rb
Lines 149 to 154 in 7a10db9
vs
opentelemetry-ruby/sdk/lib/opentelemetry/sdk/configurator.rb
Lines 163 to 168 in 7a10db9
I don't think we should change anything in our implementation, since the Ruby HTTP ecosystem really requires this distinction (almost?) everywhere. I'm just creating this issue to solicit and record agreement.
cc @mwear
The text was updated successfully, but these errors were encountered: