Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Update Appraisals for Rails 7.2 #1112

Merged
merged 4 commits into from
Aug 12, 2024
Merged

test: Update Appraisals for Rails 7.2 #1112

merged 4 commits into from
Aug 12, 2024

Conversation

kaylareopelle
Copy link
Contributor

@kaylareopelle kaylareopelle commented Aug 12, 2024 •
edited
Loading

  • Rails 7.2.0 was released on August 9, 2024. Add appraisals for the new version.
  • pg was installing activerecord 3.2, this sets a bottom limit of 6.1, the oldest supported version of Rails
  • que is not yet compatible with Rails 7.2, so set a constraint to install something between 6.1 and 7.1 (it will be compatible once Fix activerecord 7.1 deprecation warnings que-rb/que#423 is merged)

Resolves #1113

(I had this prefixed to chore, but switched it to test, not sure if one is preferred over the other)

@kaylareopelle
chore: Add Appraisals for Rails 7.2
135149a
@kaylareopelle
chore: Add ruby version conditions
30457ce 
Rails 7.2.0 requires Ruby 3.1. We test on Ruby 3.0.
Prevent running the 7.2 tests on that version.
@kaylareopelle
chore: Restrain pg and que to use Rails < 7.2.0
79d3c1c 
There is also a bottom constraint of Rails
(or Rails-related gems) 6.1.0 to prevent
cases where Rails 3.2.0 was installed instead.

The gems need updates to support Rails 7.2.
@kaylareopelle kaylareopelle changed the title chore: Add Appraisals for Rails 7.2 chore: Update Appraisals for Rails 7.2 Aug 12, 2024
@kaylareopelle kaylareopelle changed the title chore: Update Appraisals for Rails 7.2 test: Update Appraisals for Rails 7.2 Aug 12, 2024
@kaylareopelle
chore: Adjust activerecord to bottom limit of 6.1
0a147d6 
The bundle would install activerecord 3.2 without this constraint.
@kaylareopelle kaylareopelle marked this pull request as ready for review August 12, 2024 19:47
@kaylareopelle kaylareopelle requested review from a team August 12, 2024 19:47
@kaylareopelle kaylareopelle merged commit c7569f5 into open-telemetry:main Aug 12, 2024
61 checks passed
@kaylareopelle kaylareopelle deleted the add-rails-72-appraisals branch August 12, 2024 20:51
This was referenced Aug 14, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielvalentin arielvalentin arielvalentin approved these changes

@fbogsany fbogsany Awaiting requested review from fbogsany fbogsany is a code owner

@mwear mwear Awaiting requested review from mwear mwear is a code owner

@robertlaurin robertlaurin Awaiting requested review from robertlaurin robertlaurin is a code owner

@dazuma dazuma Awaiting requested review from dazuma dazuma is a code owner

@ericmustin ericmustin Awaiting requested review from ericmustin ericmustin is a code owner

@ahayworth ahayworth Awaiting requested review from ahayworth ahayworth is a code owner

@plantfansam plantfansam Awaiting requested review from plantfansam plantfansam is a code owner

@robbkidd robbkidd Awaiting requested review from robbkidd robbkidd is a code owner

@simi simi Awaiting requested review from simi simi is a code owner

@xuan-cao-swi xuan-cao-swi Awaiting requested review from xuan-cao-swi xuan-cao-swi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Rails 7.2.0
2 participants
@kaylareopelle @arielvalentin