Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Twirp Instrumentation #75

Open
2 tasks
arielvalentin opened this issue Jul 1, 2022 · 1 comment
Open
2 tasks

feat: Twirp Instrumentation #75

arielvalentin opened this issue Jul 1, 2022 · 1 comment
Labels
help wanted Extra attention is needed keep Ensures stale-bot keeps this issue/PR open

Comments

@arielvalentin
Copy link
Collaborator

https://github.com/twitchtv/twirp-ruby

  • Client instrumentation - Add RPC semantic attributes (possibly share attributes with Faraday and the adapter via HTTPClient.attributes)
  • Server instrumentation - Enrich the Rack Span with RPC server semantics and operation name, similar to how it is done with actionpack and sinatra automatic instrumentation

cc: @hmaurer

@arielvalentin arielvalentin added the help wanted Extra attention is needed label Jul 1, 2022
@github-actions
Copy link
Contributor

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

@github-actions github-actions bot added the stale Marks an issue/PR stale label Apr 27, 2023
@arielvalentin arielvalentin added keep Ensures stale-bot keeps this issue/PR open and removed stale Marks an issue/PR stale labels Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed keep Ensures stale-bot keeps this issue/PR open
Projects
None yet
Development

No branches or pull requests

1 participant