-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing instrumentation of Net::LDAP #669
Comments
We have very limited capacity and are in need of some additional instrumentation maintainers to help. Would you be interested in contributing and maintaining this instrumentation? |
@jdehaan is that instrumented already somewhere (like DataDog, NewRelic, Elastic APM)? That could make it easier to introduce this by porting. |
I can look into it, we are starting a migration to opentelemetry. At the moment I do not know how others do, I just noticed the expected traces to the authentication service didn't show up on our setup and wanted to remedy to it. I think I could provide a contribution based on how Net::HTTP is done, as it looks to me quite similar. |
What library are you currently using for instrumentation? |
None actually: own Rails logging / fluentd :-) |
👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
We are experimenting a solution available here: tools-aoeur#2. It is in an early stage. Tests are not yet provided in a sufficient amount for instance. Do you think the code looks well enough to initiate a PR here so it becomes more visibility? PS: in the meanwhile we improved the state and merged inside our fork, we are testing this productively |
👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
Hi @jdehaan , I think the solution in tools-aoeur#2 looks great. Would you mind open the PR here and we can start the review. |
Not a bug, more a feature request.
At the moment Net::LDAP is not instrumented. As the login outcome and duration are often interesting to detect issues, it would be really nice to have this instrumented as well.
The text was updated successfully, but these errors were encountered: