-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-sdk instrumentation adapter #13
Comments
Hi 👋 I'm working to create an OpenTelemetry ruby instrumentation for I wonder if there's any resources for creating instrumentation in Ruby? I'm looking for guidelines for setup the dev environment, best practices and such topics. If someone can be available and responsive it can be really helpful. Maybe I should ask the questions in the otel-ruby slack channel? Thanks |
We don't have explicit guidelines at the moment. Some things that have come up in the past:
|
@arielvalentin Thanks for your comment. |
In JS aws-sdk instrumentation there's an option to suppressInternalInstrumentation. When setting true, it hides all underlying http spans. Do you think it should be also an option in |
@YanivD You do not have to test every version, only those you intend on supporting. This repository uses the Appraisals gem combined with GitHub Actions to test multiple versions of instrumentations. The CI builds will automatically detect your appraisal file and test it against different versions on your behalf. Here is an example in the Rack Instrumentation: https://github.com/open-telemetry/opentelemetry-ruby/blob/main/instrumentation/rack/Appraisals |
I think that option would be useful. There is a utility method |
I believe this issue can be closed now, after open-telemetry/opentelemetry-ruby#1014 merged |
Convert Datadog instrumentation for aws-sdk to OpenTelemetry.
See
The text was updated successfully, but these errors were encountered: