Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active job handlers no longer honour configuration changes #1077

Closed
lavoiesl opened this issue Jul 22, 2024 · 0 comments · Fixed by #1079
Closed

Active job handlers no longer honour configuration changes #1077

lavoiesl opened this issue Jul 22, 2024 · 0 comments · Fixed by #1079

Comments

@lavoiesl
Copy link
Contributor

          This is causing a regression in our codebase because the handler no longer honours dynamic configuration.

i.e. Changing OpenTelemetry::Instrumentation::ActiveJob::Instrumentation.instance after this is registered no longer affects the naming.

Arguably, we probably shouldn't rely on dynamic configs, but I wanted to point it out regardless

Same applies to Perform

Originally posted by @lavoiesl in #677 (comment)

@lavoiesl lavoiesl changed the title Active job handlers no longer honour configuration changes. Active job handlers no longer honour configuration changes Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant