docs: add missing tests for getting started examples #4662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test_metrics.py and test_otlpcollector.py to validate the metrics_example.py and otlpcollector_example.py scripts. - test_metrics.py: Validates all 7 metric types with specific expected values - test_otlpcollector.py: Tests OTLP collector example with graceful timeout handling Fixes open-telemetry#4001
The committers listed above are authorized under a signed CLA. |
|
I think the issue was about running examples code in CI and not about writing some new tests |
My bad! 😄 i'll update! |
@xrmx - I do see that the existing tests run as part of CI. Example run from another PR that's open: https://github.com/open-telemetry/opentelemetry-python/actions/runs/15904348585/job/44855076756?pr=4659 Is there more to be done to add these tests to the CI pipeline? I see that they are configured here 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add test_metrics.py and test_otlpcollector.py to validate the metrics_example.py and otlpcollector_example.py scripts.
Fixes #4001
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist: