Add typing information for contexts, token #4346
Conversation
mrnicegyu11
changed the title
mrnicegyu11
changed the title
|
Dear maintainers, on the original PR #4164 I cannot see the details of the github action test failures, to me the code contribution by @hyoinandout looks good and mergeable. If there are incompatabilities with the python-contrib-instrumentations I am willing to look into it, but for this I'd need to see the github-action-results/failures ;) |
mrnicegyu11
changed the title
| @@ -64,7 +64,7 @@ def test_attach(self): | |||
| self.assertEqual("yyy", context.get_value("a")) | |||
|
|
|||
| with self.assertLogs(level=ERROR): | |||
| context.detach("some garbage") | |||
| context.detach("some garbage") # type:ignore | |||
There was a problem hiding this comment.
Why is the type: ignore needed?
| context.detach("some garbage") # type:ignore | |
| context.detach("some garbage") # type: ignore[?] |
There was a problem hiding this comment.
True thanks this was actually not necessary, slipped past me. I removed the type:ignore
mrnicegyu11
changed the title
There was a problem hiding this comment.
The opentelemetry/context directory needs to be included in the mypy setup.
Not related to this PR, but I already pointed out that this setup doesn't make sense. mypy needs to run once, and it should have the context of the local imports.
I've shared my thoughts here: open-telemetry/opentelemetry-python-contrib#3116 (comment)
I'm happy to push a PR switching the type checker used here, and I'm happy to help this project to have proper type hints. Otherwise, I think someone should try to make the mypy setup work properly.
I'll bring the above to the next Python SIG meeting.
Description
Trying to get #4164 in.
Opening this 1:1 similar PR for now, with changes from upstream/main, to see how the tests look. Locally, all tests are green.
This is WIP for now.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Ran the
toxfull test suite locally, all green. Waiting for maintainer approval for the github actions testsDoes This PR Require a Contrib Repo Change?
Checklist: