Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set pylint's line length to 79 chars #35

Merged
merged 2 commits into from
Jun 27, 2019
Merged

Set pylint's line length to 79 chars #35

merged 2 commits into from
Jun 27, 2019

Conversation

c24t
Copy link
Member

@c24t c24t commented Jun 27, 2019

This limits lines to 79 characters, as Guido intended. Hopefully everybody sees this as an uncontroversial and good idea.

Motivated by #29 (comment).

@c24t c24t added the style label Jun 27, 2019
Oberon00
Oberon00 approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@Oberon00 Oberon00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with that (I like being able to have more files side by side on my screen) but in my experience it is not uncontroversial 😄.

@c24t c24t merged commit 38d08e5 into open-telemetry:master Jun 27, 2019
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
@mayurkale22
Add TraceId and SpanId generator util (open-telemetry#35)
d99af90 
* Add TraceId and SpanId generator util

* minor fix

* Update file structure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@Oberon00 Oberon00 Oberon00 approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

Assignees
No one assigned
Labels
style
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@c24t @carlosalberto @Oberon00 @reyang