Bugfix django instrumentation #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rect resolver we need use request.path to replace request.get_full_path()
zzhutianyu
requested review from
a team,
toumorokoshi and
hectorhdzg
and removed request for
a team
|
Does this change strip off the query string from span name? |
|
no no no if request have query_string. The django resolve not match route so span name only "HTTP {http_method}", we want span name is django view_name or func_name or route |
toumorokoshi
suggested changes
Oct 31, 2020
| @@ -3,6 +3,7 @@ | |||
| ## Unreleased | |||
|
|
|||
| - Django instrumentation is now enabled by default but can be disabled by setting `OTEL_PYTHON_DJANGO_INSTRUMENT` to `False` ([#1239](https://github.com/open-telemetry/opentelemetry-python/pull/1239)) | |||
| - Bugfix use request.path replace request.get_full_path(). It will get correct span name ([#1309](https://github.com/open-telemetry/opentelemetry-python/pull/1309#)) | |||
There was a problem hiding this comment.
Typically with changelogs, you should try to have information that's relevant to the user, so mainly behavior. The details aren't really helpful to most.
In this case, it's sufficient to say "span name resolves correctly for paths that also require a query parameter to match".
There was a problem hiding this comment.
Thank you for your suggestion, I will pay attention to it later
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
* Basic node * Tests and functions * DefaultURL * Add JSON tests * Test rename * Refactor a lot * Restored those files * Variable anme * Fixed strings * default grpc, collector name'
lzchen
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix: Django instrumentation if request have query_string will not correct resolver we need use request.path to replace request.get_full_path()
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: