Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test that metrics methods can be called concurrently #2128

Open
ocelotl opened this issue Sep 17, 2021 · 1 comment
Open

Test that metrics methods can be called concurrently #2128

ocelotl opened this issue Sep 17, 2021 · 1 comment
Labels
api Affects the API package. metrics

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Sep 17, 2021

Originally posted by @codeboten in #1887 (comment)

This may help.
@ocelotl ocelotl mentioned this issue Sep 17, 2021
Merged
@aabmass
Copy link
Member

aabmass commented Sep 27, 2021 •
edited
Loading

@ocelotl I'll pick this up like we discussed. Some specifics are that we need to add locks around the global meter provider and potentially some other spots. Also should document concurrency guarantees in the docstrings.

@aabmass aabmass self-assigned this Sep 27, 2021
@aabmass aabmass added the api Affects the API package. label Dec 14, 2021
@lzchen lzchen added the 1.10.0rc1 release candidate 1 for metrics GA label Jan 11, 2022
@aabmass aabmass removed their assignment Mar 4, 2022
@ocelotl ocelotl removed the 1.10.0rc1 release candidate 1 for metrics GA label Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Affects the API package. metrics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aabmass @ocelotl @lzchen