Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider hiding DefaultSpan #1635

Closed
carlosalberto opened this issue Feb 25, 2021 · 3 comments · Fixed by #1661
Closed

Consider hiding DefaultSpan #1635

carlosalberto opened this issue Feb 25, 2021 · 3 comments · Fixed by #1661
Assignees
@lzchen
Labels
1.0.0rc2 release candidate 2 for tracing GA

Comments

@carlosalberto
Copy link
Contributor

According to the Spec it is recommended to not expose this functionality publicly, else it should be called NonRecordingSpan.

For example, in Java we expose this as Span.wrap(SpanContext).
@lzchen lzchen added the 1.0.0rc2 release candidate 2 for tracing GA label Feb 25, 2021
@lzchen
Copy link
Contributor

lzchen commented Mar 1, 2021

Doesn't Java have this exposed through PropagatedSpan? How is that any different than DefaultSpan?

@carlosalberto
Copy link
Contributor Author

PropagatedSpan is no longer a public class, so the user has to call Span.wrap(SpanContext spanCtx) instead.

@codeboten
Copy link
Contributor

My vote is to rename Default to NonRecordingSpan

@lzchen lzchen self-assigned this Mar 1, 2021
@lzchen lzchen mentioned this issue Mar 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lzchen lzchen

Labels
1.0.0rc2 release candidate 2 for tracing GA
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename DefaultSpan to NonRecordingSpan lzchen/opentelemetry-python
3 participants
@codeboten @carlosalberto @lzchen