Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Tracer is safe for concurrent calls #1156

Closed
codeboten opened this issue Sep 24, 2020 · 1 comment
Closed

Validate Tracer is safe for concurrent calls #1156

codeboten opened this issue Sep 24, 2020 · 1 comment
Assignees
Labels
help wanted release:required-for-ga To be resolved before GA release

Comments

@codeboten
Copy link
Contributor

Part of the work required for GA is to validate that the Tracer is safe for concurrent calls. Ideally this issue would be resolved by adding tests to validate this.

@codeboten codeboten added help wanted release:required-for-ga To be resolved before GA release labels Sep 24, 2020
@codeboten codeboten self-assigned this Oct 16, 2020
@codeboten
Copy link
Contributor Author

Having reviewed the methods available in the Tracer API and their implementations in the SDK:

  • start_span: threadsafe
  • use_span: uses the context api which is threadlocal or contextvars for storage. any calls to the span API are either atomic, or are using a lock where needed ie. end here:
    def end(self, end_time: Optional[int] = None) -> None:
    with self._lock:
  • start_as_current_span: uses start_span and use_span which have both been reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted release:required-for-ga To be resolved before GA release
Projects
None yet
Development

No branches or pull requests

1 participant