Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTLP exporter should support multi-destination exporting #1109

Open
codeboten opened this issue Sep 14, 2020 · 6 comments
Open

OTLP exporter should support multi-destination exporting #1109

codeboten opened this issue Sep 14, 2020 · 6 comments
Assignees
Labels
doc Documentation-related exporters feature-request good first issue Good first issue help wanted release:required-for-ga To be resolved before GA release

Comments

@codeboten
Copy link
Contributor

As per spec: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/protocol/otlp.md#multi-destination-exporting

@codeboten codeboten added 1.0.0rc2 release candidate 2 for tracing GA release:required-for-ga To be resolved before GA release labels Nov 26, 2020
@codeboten codeboten removed the 1.0.0rc2 release candidate 2 for tracing GA label Feb 25, 2021
@seemk
Copy link
Contributor

seemk commented Mar 3, 2021

With each exporter contained within BatchSpanProcessor which has its own queue, isn't this the case already? So you just create multiple exporters?

@owais
Copy link
Contributor

owais commented Mar 6, 2021

I agree. We can consider using multiple processor each with it's own instance of OTLP exporter as a solution for this. Looks like the spec just recommends having one queue per destination which would be satisfied by such a setup. There's no point in re-implementing BatchSpanProcessor's queue inside the exporter IMO.

If we agree with this, this should just be a small documentation change.

@owais
Copy link
Contributor

owais commented Mar 6, 2021

Using multiple exports+processors does probably not technically satisfy the spec as the spec clearly talks about multi-destination exporting in the context of OTLP exporter but still, we can still recommend wrapping multiple OTLP exporters with different processors to achieve the same result. I realize it may not truly satisfy the spec but it addresses the problem the spec is trying to solve in a rather elegant way without adding too much logic/responsibility to the exporter.

@lzchen
Copy link
Contributor

lzchen commented Mar 8, 2021

@owais
I agree. The less changes we make the better. So this will just simply be a doc change then to instruct users to go that route to solve this usecase?

@github-actions
Copy link

github-actions bot commented Apr 9, 2021

This issue was marked stale due to lack of activity. It will be closed in 30 days.

@owais
Copy link
Contributor

owais commented Apr 9, 2021

I somehow missed your comment @lzchen. Yes, I think we should document "how to export to multiple destinations" and it should cover using different exporters or multiple instances of same exporter.

@owais owais added the good first issue Good first issue label Apr 9, 2021
@github-actions github-actions bot removed the backlog label Apr 10, 2021
@codeboten codeboten self-assigned this Apr 19, 2021
@lzchen lzchen added the doc Documentation-related label May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation-related exporters feature-request good first issue Good first issue help wanted release:required-for-ga To be resolved before GA release
Projects
None yet
Development

No branches or pull requests

4 participants