Skip to content

Commit e78675e

Browse files
authored
Fix ExponentialBucketHistogramAggregation (#3978)
* Refactor __init__ * Refactor aggregate * Handle case for DELTA DELTA * Checkpoint before removing old code * Remove old code * Fix some test cases * Relocate method * Debugging test_aggregate_collect * Fix empty previous bucket handling * Fix max and min setting * Fix explicit bucket aggregation to make it consistent * Rearrange __init__s * Set scale in aggregate * Use right values in exponential point * Set scale right * Start scale as None * Make test_collect_results_cumulative pass I am not sure these changes are right, I just wanted to find what would be the value that would make this test case pass. * Actually use random values * Add integration test for exponential histogram * Handle all cases for current and previous buckets and scale * Rename test module * Use random values * Fix bucket setting * WIP integration test * WIP * Finish integration tests * Rename variables * Explain analogy with ExplicitBucket * Add changelog and fix lint * Fix equality tests * Fix location of returns * Fix another issue and add test case * Added comments to integration test case * Fix lint * Add documentation for test case
1 parent b1e99c1 commit e78675e

File tree

6 files changed

+933
-439
lines changed

6 files changed

+933
-439
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2121
([#3956](https://github.com/open-telemetry/opentelemetry-python/pull/3956))
2222
- When encountering an error encoding metric attributes in the OTLP exporter, log the key that had an error.
2323
([#3838](https://github.com/open-telemetry/opentelemetry-python/pull/3838))
24+
- Fix `ExponentialHistogramAggregation`
25+
([#3978](https://github.com/open-telemetry/opentelemetry-python/pull/3978))
2426
- Log a warning when a `LogRecord` in `sdk/log` has dropped attributes
2527
due to reaching limits
2628
([#3946](https://github.com/open-telemetry/opentelemetry-python/pull/3946))

0 commit comments

Comments
 (0)