Add Unit Test

open-telemetry · Oct 30, 2020 · c24c6e2 · c24c6e2
1 parent fb9fd8c
commit c24c6e2
Showing 1 changed file with 14 additions and 0 deletions.
diff --git a/instrumentation/opentelemetry-instrumentation-django/tests/test_middleware.py b/instrumentation/opentelemetry-instrumentation-django/tests/test_middleware.py
@@ -250,6 +250,7 @@ def test_exclude_lists(self):
         self.assertEqual(len(span_list), 1)
 
     def test_span_name(self):
+        # test no query_string
         Client().get("/span_name/1234/")
         span_list = self.memory_exporter.get_finished_spans()
         self.assertEqual(len(span_list), 1)
@@ -262,6 +263,19 @@ def test_span_name(self):
             else "tests.views.route_span_name",
         )
 
+        # test have query_string
+        Client().get("/span_name/1234/?query=test")
+        span_list = self.memory_exporter.get_finished_spans()
+        self.assertEqual(len(span_list), 1)
+
+        span = span_list[0]
+        self.assertEqual(
+            span.name,
+            "^span_name/([0-9]{4})/$"
+            if DJANGO_2_2
+            else "tests.views.route_span_name",
+        )
+
     def test_span_name_404(self):
         Client().get("/span_name/1234567890/")
         span_list = self.memory_exporter.get_finished_spans()