Skip to content

Commit 9676505

Browse files
authored
Fix prepare patch release workflow (#4287)
1 parent ea809eb commit 9676505

File tree

3 files changed

+69
-1
lines changed

3 files changed

+69
-1
lines changed
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
#!/bin/bash -e
2+
3+
sed -i "/\[stable\]/{n;s/version=.*/version=$1/}" eachdist.ini
4+
sed -i "/\[prerelease\]/{n;s/version=.*/version=$2/}" eachdist.ini
5+
6+
./scripts/eachdist.py update_patch_versions \
7+
--stable_version=$1 \
8+
--unstable_version=$2 \
9+
--stable_version_prev=$3 \
10+
--unstable_version_prev=$4
11+

.github/workflows/prepare-patch-release.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,14 +43,18 @@ jobs:
4343
exit 1
4444
fi
4545
46+
stable_version_prev="$stable_major_minor.$((stable_patch))"
47+
unstable_version_prev="0.${unstable_minor}b$((unstable_patch))"
4648
stable_version="$stable_major_minor.$((stable_patch + 1))"
4749
unstable_version="0.${unstable_minor}b$((unstable_patch + 1))"
4850
4951
echo "STABLE_VERSION=$stable_version" >> $GITHUB_ENV
5052
echo "UNSTABLE_VERSION=$unstable_version" >> $GITHUB_ENV
53+
echo "STABLE_VERSION_PREV=$stable_version_prev" >> $GITHUB_ENV
54+
echo "UNSTABLE_VERSION_PREV=$unstable_version_prev" >> $GITHUB_ENV
5155
5256
- name: Update version
53-
run: .github/scripts/update-version.sh $STABLE_VERSION $UNSTABLE_VERSION
57+
run: .github/scripts/update-version-patch.sh $STABLE_VERSION $UNSTABLE_VERSION $STABLE_VERSION_PREV $UNSTABLE_VERSION_PREV
5458

5559
- name: Update the change log with the approximate release date
5660
run: |

scripts/eachdist.py

Lines changed: 53 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -236,6 +236,16 @@ def setup_instparser(instparser):
236236
"releaseargs", nargs=argparse.REMAINDER, help=extraargs_help("pytest")
237237
)
238238

239+
patchreleaseparser = subparsers.add_parser(
240+
"update_patch_versions",
241+
help="Updates version numbers during patch release, used by maintainers and CI",
242+
)
243+
patchreleaseparser.set_defaults(func=patch_release_args)
244+
patchreleaseparser.add_argument("--stable_version", required=True)
245+
patchreleaseparser.add_argument("--unstable_version", required=True)
246+
patchreleaseparser.add_argument("--stable_version_prev", required=True)
247+
patchreleaseparser.add_argument("--unstable_version_prev", required=True)
248+
239249
fmtparser = subparsers.add_parser(
240250
"format",
241251
help="Formats all source code with black and isort.",
@@ -599,6 +609,23 @@ def update_dependencies(targets, version, packages):
599609
)
600610

601611

612+
def update_patch_dependencies(targets, version, prev_version, packages):
613+
print("updating patch dependencies")
614+
# PEP 508 allowed specifier operators
615+
operators = ["==", "!=", "<=", ">=", "<", ">", "===", "~=", "="]
616+
operators_pattern = "|".join(re.escape(op) for op in operators)
617+
618+
for pkg in packages:
619+
search = rf"({basename(pkg)}[^,]*)(\s?({operators_pattern})\s?)(.*{prev_version})"
620+
replace = r"\1\2 " + version
621+
update_files(
622+
targets,
623+
"pyproject.toml",
624+
search,
625+
replace,
626+
)
627+
628+
602629
def update_files(targets, filename, search, replace):
603630
errors = False
604631
for target in targets:
@@ -640,6 +667,32 @@ def release_args(args):
640667
update_version_files(targets, version, packages)
641668

642669

670+
def patch_release_args(args):
671+
print("preparing patch release")
672+
673+
rootpath = find_projectroot()
674+
targets = list(find_targets_unordered(rootpath))
675+
cfg = ConfigParser()
676+
cfg.read(str(find_projectroot() / "eachdist.ini"))
677+
# stable
678+
mcfg = cfg["stable"]
679+
packages = mcfg["packages"].split()
680+
print(f"update stable packages to {args.stable_version}")
681+
update_patch_dependencies(
682+
targets, args.stable_version, args.stable_version_prev, packages
683+
)
684+
update_version_files(targets, args.stable_version, packages)
685+
686+
# prerelease
687+
mcfg = cfg["prerelease"]
688+
packages = mcfg["packages"].split()
689+
print(f"update prerelease packages to {args.unstable_version}")
690+
update_patch_dependencies(
691+
targets, args.unstable_version, args.unstable_version_prev, packages
692+
)
693+
update_version_files(targets, args.unstable_version, packages)
694+
695+
643696
def test_args(args):
644697
clean_remainder_args(args.pytestargs)
645698
execute_args(

0 commit comments

Comments
 (0)