Skip to content

Commit 7551e26

Browse files
brettimusBrett Beutell
authored and
Brett Beutell
committed
Reformat code that violated linting rules
1 parent 326a315 commit 7551e26

File tree

3 files changed

+27
-7
lines changed

3 files changed

+27
-7
lines changed

exporter/opentelemetry-exporter-prometheus/src/opentelemetry/exporter/prometheus/__init__.py

Lines changed: 20 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -244,13 +244,25 @@ def _translate_to_prometheus(
244244
for pre_metric_family_id, label_values, value in zip(
245245
pre_metric_family_ids, label_valuess, values
246246
):
247-
is_non_monotonic_sum = isinstance(metric.data, Sum) and metric.data.is_monotonic == False
248-
is_cumulative = isinstance(metric.data, Sum) and metric.data.aggregation_temporality == AggregationTemporality.CUMULATIVE
247+
is_non_monotonic_sum = (
248+
isinstance(metric.data, Sum)
249+
and metric.data.is_monotonic == False
250+
)
251+
is_cumulative = (
252+
isinstance(metric.data, Sum)
253+
and metric.data.aggregation_temporality
254+
== AggregationTemporality.CUMULATIVE
255+
)
249256

250257
# The prometheus compatibility spec for sums says: If the aggregation temporality is cumulative and the sum is non-monotonic, it MUST be converted to a Prometheus Gauge.
251-
should_convert_sum_to_gauge = (is_non_monotonic_sum and is_cumulative)
258+
should_convert_sum_to_gauge = (
259+
is_non_monotonic_sum and is_cumulative
260+
)
252261

253-
if isinstance(metric.data, Sum) and not should_convert_sum_to_gauge:
262+
if (
263+
isinstance(metric.data, Sum)
264+
and not should_convert_sum_to_gauge
265+
):
254266

255267
metric_family_id = "|".join(
256268
[pre_metric_family_id, CounterMetricFamily.__name__]
@@ -268,7 +280,10 @@ def _translate_to_prometheus(
268280
metric_family_id_metric_family[
269281
metric_family_id
270282
].add_metric(labels=label_values, value=value)
271-
elif isinstance(metric.data, Gauge) or should_convert_sum_to_gauge:
283+
elif (
284+
isinstance(metric.data, Gauge)
285+
or should_convert_sum_to_gauge
286+
):
272287

273288
metric_family_id = "|".join(
274289
[pre_metric_family_id, GaugeMetricFamily.__name__]

exporter/opentelemetry-exporter-prometheus/tests/test_prometheus_exporter.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ def test_non_monotonic_sum_to_prometheus(self):
171171
attributes=labels,
172172
description="testdesc",
173173
unit="testunit",
174-
is_monotonic=False
174+
is_monotonic=False,
175175
)
176176

177177
metrics_data = MetricsData(

tests/opentelemetry-test-utils/src/opentelemetry/test/metrictestutil.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,12 @@ def _generate_metric(
3939

4040

4141
def _generate_sum(
42-
name, value, attributes=None, description=None, unit=None, is_monotonic=True
42+
name,
43+
value,
44+
attributes=None,
45+
description=None,
46+
unit=None,
47+
is_monotonic=True,
4348
) -> Metric:
4449
if attributes is None:
4550
attributes = BoundedAttributes(attributes={"a": 1, "b": True})

0 commit comments

Comments
 (0)