opentelemetry-instrumentation-system-metrics: add OTEL_PYTHON_SYSTEM_METRICS_EXCLUDED_METRICS environment variable #3959
+271
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herin049
changed the title
herin049
force-pushed
the
feature/system-metrics-env-var-conf
branch
from
09bb5bf to
263b603
Compare
|
Can confirm that this worked as expected. |
xrmx
reviewed
Nov 24, 2025
| for pat in os.environ.get( | ||
| OTEL_PYTHON_SYSTEM_METRICS_EXCLUDED_METRICS, "" | ||
| ).split(",") | ||
| if pat |
Contributor
There was a problem hiding this comment.
Suggested change
| if pat | |
| if pat.strip() |
To avoid empty strings if there are spaces in the env var
Comment on lines
44
to
46
| - ``?`` - Matches any single character | ||
| - ``[seq]`` - Matches any character in the sequence | ||
| - ``[!seq]`` - Matches any character not in the sequence |
Contributor
There was a problem hiding this comment.
For this specific use case I think maybe we can limit the documented glob pattern to the * unless is there an obvious use case I'm missing?
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements #3954 to add support for the
OTEL_PYTHON_SYSTEM_METRICS_EXCLUDED_METRICSenvironment variable in order to selectively exclude certain metrics from being exported.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Several test scenarios have been added to test the new environment variable configuration option.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.