Skip to content

Conversation

@xrmx
Copy link
Contributor

@xrmx xrmx commented Jan 28, 2025

Description

This code has been written from scratch, only the one in __init__.py contains some bits from Amazon code.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

These code has been written from scratch
@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 28, 2025
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it much Amazon code?

@xrmx
Copy link
Contributor Author

xrmx commented Jan 28, 2025

Is it much Amazon code?

Amazon code is the helpers in __init__.py to extract request and response attributes for titan and nova models from the first PR and some code around the StreamingBody handling. So not that much.

@xrmx xrmx enabled auto-merge (squash) January 28, 2025 20:14
@xrmx xrmx merged commit 7af1918 into open-telemetry:main Jan 28, 2025
694 checks passed
aryabharat pushed a commit to aryabharat/opentelemetry-python-contrib that referenced this pull request Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants