Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elasticsearch: stop testing on ancient versions #2422

Merged

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Apr 15, 2024

Description

Pick 6.0 as the baseline. Elasticsearch 2 client was EOL in 2018, Elasticsearch 5 in 2019.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 15, 2024
@xrmx xrmx requested a review from a team April 15, 2024 15:29
@xrmx
Copy link
Contributor Author

xrmx commented Apr 16, 2024

Looking at the stats there are still 100K downloads a month for elasticsearch5, may just drop just 2. Still there are not have been releases since 2019.

@xrmx xrmx marked this pull request as draft April 16, 2024 07:44
@xrmx
Copy link
Contributor Author

xrmx commented Apr 17, 2024

Looking at the stats there are still 100K downloads a month for elasticsearch5, may just drop just 2. Still there are not have been releases since 2019.

5 has been EOL since 2019 though, probably not many people using opentelemetry with it.

@xrmx xrmx marked this pull request as ready for review April 17, 2024 08:44
@xrmx xrmx force-pushed the drop-ancient-elasticsearch-versions-tests branch from e87f599 to a78a753 Compare April 17, 2024 08:45
@tammy-baylis-swi
Copy link
Contributor

5 has been EOL since 2019 though, probably not many people using opentelemetry with it.

I think it's fair to drop 5 support, then also add a changelog entry under Breaking changes subheader.

@xrmx xrmx force-pushed the drop-ancient-elasticsearch-versions-tests branch from daed9f7 to fa36331 Compare April 17, 2024 19:03
@xrmx
Copy link
Contributor Author

xrmx commented Apr 17, 2024

5 has been EOL since 2019 though, probably not many people using opentelemetry with it.

I think it's fair to drop 5 support, then also add a changelog entry under Breaking changes subheader.

Done

@xrmx
Copy link
Contributor Author

xrmx commented Apr 18, 2024

@ocelotl I have in the pipeline testing for newer elasticsearch versions so the version is useful to keep

@xrmx xrmx force-pushed the drop-ancient-elasticsearch-versions-tests branch from b5a2b6d to f6f307a Compare April 18, 2024 07:37
@xrmx xrmx removed the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 18, 2024
@ocelotl
Copy link
Contributor

ocelotl commented Apr 18, 2024

@ocelotl I have in the pipeline testing for newer elasticsearch versions so the version is useful to keep

We are no longer using package versions in the naming of test requirements files, if more testing is added for elasticsearch that uses different versions, the test requirements files are numbered from 0 onwards.

@ocelotl ocelotl merged commit 4de0e56 into open-telemetry:main Apr 18, 2024
259 checks passed
@xrmx
Copy link
Contributor Author

xrmx commented Apr 22, 2024

@ocelotl I have in the pipeline testing for newer elasticsearch versions so the version is useful to keep

We are no longer using package versions in the naming of test requirements files, if more testing is added for elasticsearch that uses different versions, the test requirements files are numbered from 0 onwards.

AFAIR there was agreement that reinstating the more semantic versioning after your PRs reworking tests was fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants