-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pika): adding support for channel.consume instrumentation #2397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galbash
force-pushed
the
pika-consume
branch
2 times, most recently
from
April 8, 2024 13:40
6201424
to
336478a
Compare
nemoshlag
reviewed
Apr 8, 2024
...mentation/opentelemetry-instrumentation-pika/src/opentelemetry/instrumentation/pika/utils.py
Outdated
Show resolved
Hide resolved
nemoshlag
approved these changes
Apr 8, 2024
shalevr
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An attempt at adding support for pika's
channel.consume
function (today we only supportbasic_get
andbasic_consume
.Fixes #1432
Currently works only as a global instrumentation (using
PikaInstrumentor.instrument()
) and not for a per-channel instrumentation (usingPikaInstrumentor.instrument_channel(c)
). This is due to an implementation difficulty.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.