Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove [test] packages #2182

Closed
47 tasks done
ocelotl opened this issue Feb 15, 2024 · 3 comments
Closed
47 tasks done

Remove [test] packages #2182

ocelotl opened this issue Feb 15, 2024 · 3 comments
Assignees

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Feb 15, 2024

We are using [test] packages. This feature is not intented to be used this way, it is intended to be used to support additional features of a package. Besides this, we are actually creating new packages that our users can install which I don't think is a good idea since it increases the amount of "things" we have to support.

There is no standard way of defining the test dependencies or a package.

I suggest we use an extra file in every package to define the test dependencies for every package. This will also help with the additional problem that is the tox.ini file growing very large and hard to understand since all the package testing dependencies are there.

@ocelotl ocelotl added the bug Something isn't working label Feb 15, 2024
@ocelotl ocelotl self-assigned this Feb 15, 2024
This was referenced Feb 15, 2024
This was referenced Feb 15, 2024
@ocelotl ocelotl removed the bug Something isn't working label Feb 15, 2024
@federicobond
Copy link
Member

We should remove the [test] package from psycopg instrumentation too.

@xrmx
Copy link
Contributor

xrmx commented Jul 9, 2024

@ocelotl we can close this right?

@ocelotl
Copy link
Contributor Author

ocelotl commented Sep 3, 2024

Yes, closing.

@ocelotl ocelotl closed this as completed Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants