-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hook to set custom span name in django instrumentation #138
Comments
I can take on this issue! @NickSulistio cc @alolita |
@NickSulistio I added request/response hooks to Django instrumentation. They can be used to set span name (among other things) on the server span. I think adding a special hook just for span name would be redundant after these changes. Sorry about not notifying you earlier about this. Good news is that we need similar request/response hooks for all web server instrumentations such as flask, falcon, tornado etc and you can implement that if you'd like. Let me know if that's interesting to you and we can discuss it. |
More details: #408 |
Hi @owais, do you think that these would be good first issues? This is the first time I'm contributing to an open source project, so I think that if this issues are not too complicated then I would be willing to take them! |
Yes, they're the same complexity as the span name callback was. They're very similar actually. Feel free to ping me on slack if you need help with anything. |
Similar to wsgi, accept a callback function in
DjangoInstrumentor().instrument
to be able to pass custom span name.The specs say "MAY" for this feature, but we should be consistent across our instrumentations.
Part of open-telemetry/opentelemetry-python#1297
The text was updated successfully, but these errors were encountered: