linting fixes

Author: keith-decker

util/opentelemetry-util-genai/__init__.py

@@ -74,8 +74,8 @@ class _SpanState:
 
 def _get_property_value(obj: Any, property_name: str) -> Any:
     if isinstance(obj, Mapping):
-        m = cast(Mapping[str, Any], obj)
-        return m.get(property_name, None)
+        mapping = cast(Mapping[str, Any], obj)
+        return mapping.get(property_name)
 
     return cast(Any, getattr(obj, property_name, None))
 

util/opentelemetry-util-genai/src/__init__.py

@@ -156,19 +156,21 @@ def fail_llm(
         return invocation
 
 
-# Singleton accessor
-_default_handler: Optional[TelemetryHandler] = None
+# Singleton accessor (avoid global statement by storing on function attribute)
 
 
 def get_telemetry_handler(
     emitter_type_full: bool = True, **kwargs: Any
 ) -> TelemetryHandler:
-    global _default_handler
-    if _default_handler is None:
-        _default_handler = TelemetryHandler(
+    handler: Optional[TelemetryHandler] = getattr(
+        get_telemetry_handler, "_default_handler", None
+    )
+    if handler is None:
+        handler = TelemetryHandler(
             emitter_type_full=emitter_type_full, **kwargs
         )
-    return _default_handler
+        setattr(get_telemetry_handler, "_default_handler", handler)
+    return handler
 
 
 # Module‐level convenience functions

util/opentelemetry-util-genai/src/opentelemetry/__init__.py

@@ -18,8 +18,8 @@
 )
 
 
-@pytest.fixture
-def telemetry_setup():
+@pytest.fixture(name="span_exporter")
+def span_exporter_fixture():
     """Set up telemetry providers for testing"""
     # Set up in-memory span exporter to capture spans
     memory_exporter = InMemorySpanExporter()
@@ -37,8 +37,9 @@ def telemetry_setup():
     trace.set_tracer_provider(trace.NoOpTracerProvider())
 
 
+@pytest.mark.usefixtures("span_exporter")
 def test_llm_start_and_stop_creates_span(
-    telemetry_setup: InMemorySpanExporter,
+    request: pytest.FixtureRequest,
 ):
     run_id = uuid4()
     message = Message(content="hello world", type="Human", name="message name")
@@ -53,7 +54,8 @@ def test_llm_start_and_stop_creates_span(
     )
 
     # Get the spans that were created
-    spans = telemetry_setup.get_finished_spans()
+    exporter: InMemorySpanExporter = request.getfixturevalue("span_exporter")
+    spans = exporter.get_finished_spans()
 
     # Verify span was created
     assert len(spans) == 1