Skip to content

Commit a2da45b

Browse files
committed
changing according to comment and make lint pass
Signed-off-by: Jack Gong <Benhua.Gong@fmr.com>
1 parent 48524f1 commit a2da45b

File tree

1 file changed

+31
-7
lines changed

1 file changed

+31
-7
lines changed

instrumentation/opentelemetry-instrumentation-fastapi/tests/test_fastapi_instrumentation.py

Lines changed: 31 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -565,7 +565,9 @@ def test_basic_metric_success_new_semconv(self):
565565
)
566566
self.assertEqual(point.count, 1)
567567
if metric.name == "http.server.request.duration":
568-
self.assertAlmostEqual(duration_s * 0.1, point.sum , places=1)
568+
self.assertAlmostEqual(
569+
duration_s * 0.1, point.sum, places=1
570+
)
569571
elif metric.name == "http.server.response.body.size":
570572
self.assertEqual(25, point.sum)
571573
elif metric.name == "http.server.request.body.size":
@@ -617,7 +619,9 @@ def test_basic_metric_success_both_semconv(self):
617619
self.assertEqual(point.count, 1)
618620
self.assertAlmostEqual(duration, point.sum, delta=350)
619621
if metric.name == "http.server.request.duration":
620-
self.assertAlmostEqual(duration_s * 0.1, point.sum , places=1)
622+
self.assertAlmostEqual(
623+
duration_s * 0.1, point.sum, places=1
624+
)
621625
self.assertDictEqual(
622626
expected_duration_attributes_new,
623627
dict(point.attributes),
@@ -726,7 +730,9 @@ def test_basic_metric_nonstandard_http_method_success_new_semconv(self):
726730
)
727731
self.assertEqual(point.count, 1)
728732
if metric.name == "http.server.request.duration":
729-
self.assertAlmostEqual(duration_s * 0.1, point.sum , places=1)
733+
self.assertAlmostEqual(
734+
duration_s * 0.1, point.sum, places=1
735+
)
730736
elif metric.name == "http.server.response.body.size":
731737
self.assertEqual(31, point.sum)
732738
elif metric.name == "http.server.request.body.size":
@@ -777,7 +783,9 @@ def test_basic_metric_nonstandard_http_method_success_both_semconv(self):
777783
if isinstance(point, HistogramDataPoint):
778784
self.assertEqual(point.count, 1)
779785
if metric.name == "http.server.request.duration":
780-
self.assertAlmostEqual(duration_s * 0.1, point.sum , places=1)
786+
self.assertAlmostEqual(
787+
duration_s * 0.1, point.sum, places=1
788+
)
781789
self.assertDictEqual(
782790
expected_duration_attributes_new,
783791
dict(point.attributes),
@@ -861,7 +869,9 @@ def test_basic_post_request_metric_success_new_semconv(self):
861869
if isinstance(point, HistogramDataPoint):
862870
self.assertEqual(point.count, 1)
863871
if metric.name == "http.server.request.duration":
864-
self.assertAlmostEqual(duration_s * 0.1, point.sum , places=1)
872+
self.assertAlmostEqual(
873+
duration_s * 0.1, point.sum, places=1
874+
)
865875
elif metric.name == "http.server.response.body.size":
866876
self.assertEqual(response_size, point.sum)
867877
elif metric.name == "http.server.request.body.size":
@@ -887,7 +897,9 @@ def test_basic_post_request_metric_success_both_semconv(self):
887897
if isinstance(point, HistogramDataPoint):
888898
self.assertEqual(point.count, 1)
889899
if metric.name == "http.server.request.duration":
890-
self.assertAlmostEqual(duration_s * 0.1, point.sum , places=1)
900+
self.assertAlmostEqual(
901+
duration_s * 0.1, point.sum, places=1
902+
)
891903
elif metric.name == "http.server.response.body.size":
892904
self.assertEqual(response_size, point.sum)
893905
elif metric.name == "http.server.request.body.size":
@@ -1069,6 +1081,18 @@ def test_uninstrument_after_instrument(self):
10691081
spans = self.memory_exporter.get_finished_spans()
10701082
self.assertEqual(len(spans), 3)
10711083

1084+
def test_no_op_tracer_provider(self):
1085+
self._instrumentor.uninstrument()
1086+
self._instrumentor.instrument(
1087+
tracer_provider=trace.NoOpTracerProvider()
1088+
)
1089+
1090+
app = self._create_fastapi_app()
1091+
client = TestClient(app)
1092+
client.get("/foobar")
1093+
spans = self.memory_exporter.get_finished_spans()
1094+
self.assertEqual(len(spans), 0)
1095+
10721096
def tearDown(self):
10731097
self._instrumentor.uninstrument()
10741098
super().tearDown()
@@ -1758,4 +1782,4 @@ def test_custom_header_not_present_in_non_recording_span(self):
17581782
)
17591783
self.assertEqual(200, resp.status_code)
17601784
span_list = self.memory_exporter.get_finished_spans()
1761-
self.assertEqual(len(span_list), 0)
1785+
self.assertEqual(len(span_list), 0)

0 commit comments

Comments
 (0)