-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a oneof for Histogram buckets; add ExplicitBuckets; deprecate DoubleHistogram #272
Conversation
…lex topic for the .proto file
@jmacd and some folks had an offline chat, and I want us to make a decision between multiple bucket types vs multiple histogram types:
|
These allocations will be real costs in the collector, but they're not a big deal in SDKs where the export frequency is relatively low. A fancy protocol buffer implementation would help, for the collector case.
Note that in #264 (comment) is a proposal to place parallel repeated fields into the Gauge, Sum, and Histogram points to reflect number-type variation. In #259, you propose to add per-bucket-style Histogram value types to the
In both cases, with number-type variation and with bucket-style variation, we do not see a semantic conflict but there is loss of information if we convert between them. By supporting parallel fields we reduce the number of overall oneofs, and we prevent users from having to observe parallel histograms or sums/gauges when there is only bucket-style or number-type variation. We avoid an allocation (however the points are correspondingly larger by 24 bytes in the collector case.). |
Is the |
Co-authored-by: Aaron Abbott <aaronabbott@google.com>
@hdost Exponential buckets will handle high dynamic range. It is different from http://hdrhistogram.org/ in that http://hdrhistogram.org/ use "log linear" (linear subbuckets in log buckets), while Exponential will use log buckets only, for wider compatibility. We might add support for log linear in the future. |
See open-telemetry/oteps#149 (Add exponential bucketing to histogram protobuf) |
@open-telemetry/specs-metrics-approvers note this PR fully incorporates #270. |
We have decided to let each distinct form of histogram have its own data point kind. |
This deprecates the existing DoubleHistogram and creates a new one with room for more histogram types to be added in the future.
The oneof proposed here was first described in the issue #259 (comment) and has support from contributors working on #226, e.g., #226 (comment).
Fixes #259.
Alternate to #255.