Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix port derivation #651

Merged
merged 16 commits into from
Jan 11, 2022
Merged

Fix port derivation #651

merged 16 commits into from
Jan 11, 2022

Conversation

yuriolisa
Copy link
Contributor

@yuriolisa yuriolisa commented Dec 22, 2021 •
edited by pavolloffay
Loading

  • Change the approach to extract endpoint ports.
  • Creating tests to test it.

Resolves #646

@yuriolisa yuriolisa requested review from a team and jpkrohling December 22, 2021 14:05
@yuriolisa
Copy link
Contributor Author

Fixes #646

VineethReddy02
VineethReddy02 requested changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@VineethReddy02 VineethReddy02 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some changes

pavolloffay
pavolloffay reviewed Jan 3, 2022
View reviewed changes
pkg/collector/parser/receiver.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
pavolloffay
pavolloffay approved these changes Jan 11, 2022
View reviewed changes
pkg/collector/parser/receiver.go Outdated Show resolved Hide resolved
VineethReddy02
VineethReddy02 reviewed Jan 11, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
VineethReddy02
VineethReddy02 approved these changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@VineethReddy02 VineethReddy02 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some refactoring on error case evaluation.

VineethReddy02
VineethReddy02 requested changes Jan 11, 2022
View reviewed changes
pkg/collector/parser/receiver.go Outdated Show resolved Hide resolved
@VineethReddy02 VineethReddy02 merged commit 1f1fa71 into open-telemetry:main Jan 11, 2022
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
@yuriolisa
Fix port derivation (open-telemetry#651)
ecac8e4 
* Fix port derivation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VineethReddy02 VineethReddy02 VineethReddy02 approved these changes

@pavolloffay pavolloffay pavolloffay approved these changes

@jpkrohling jpkrohling Awaiting requested review from jpkrohling

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parsing httpd endpoint in Otel-operator is broken.
3 participants
@yuriolisa @pavolloffay @VineethReddy02