Filter out unneeded labels #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekarlso
force-pushed
the
issue-605
branch
3 times, most recently
from
4f0a177
to
c9023e1
Compare
jpkrohling
changed the title
jpkrohling
requested review from
jpkrohling
and removed request for
bogdandrutu
jpkrohling
reviewed
Dec 6, 2021
ekarlso
force-pushed
the
issue-605
branch
3 times, most recently
from
36b5dd9
to
61faf60
Compare
jpkrohling
reviewed
Dec 7, 2021
- 10.98.72.0/21
jpkrohling
reviewed
Mar 9, 2022
jpkrohling
approved these changes
Mar 14, 2022
I think it will totally depend on you setup but yeah if you want me to add docs please say where :) |
|
I'm merging so that this gets into the next release, even if the documentation is missing. Please, document it either in the readme, or with an e2e test, showing how to use this feature. If it's not documented, it doesn't exist. |
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Fixes open-telemetry#605 - Filter out unneeded labels - 10.98.72.0/21 * Remove second parse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #605