Change the default port for OTLP HTTP

[joaopgrassi]

From the issue:

• make sure we create a new -legacy port, for 55681
• change the default port from 55681 to 4318
• schedule a ticket to remove the legacy port in two releases

resolves #371

[joaopgrassi]

Hey all,
I tried running the tests locally before opening the PR, but I ran into this issue:

o install sigs.k8s.io/kustomize/kustomize/v3@v3.5.4: sigs.k8s.io/kustomize/kustomize/v3@v3.5.4
	The go.mod file for the module providing named packages contains one or
	more exclude directives. It must not contain directives that would cause
	it to be interpreted differently than if it were the main module.
make: *** [Makefile:155: kustomize] Error 1

My Go installation is: go version go1.16.6 linux/amd64 I tried running make test with minikube and also by using kubebuilder (installed using the install-kubebuilder.sh file)

I'm rather new to go, so sorry if this is a stupid question 🙈

[jpkrohling]

LGTM!

[jpkrohling]

I don't see the same problem as you are seeing. I do get a test failure, though:

$ make test
/home/jpkroehling/go/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
go fmt ./...
go vet ./...
/home/jpkroehling/go/bin/controller-gen "crd:trivialVersions=true,preserveUnknownFields=false,generateEmbeddedObjectMeta=true" rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd/bases
cd config/manager && /home/jpkroehling/bin/kustomize edit set image controller=quay.io/opentelemetry/opentelemetry-operator:v"0.31.0"
/usr/bin/operator-sdk generate kustomize manifests -q
WARN[0000] Skipping definitions parsing for API {}: Go type not found 
/home/jpkroehling/bin/kustomize build config/manifests | /usr/bin/operator-sdk generate bundle -q --overwrite --manifests --version "0.31.0"  
/usr/bin/operator-sdk bundle validate ./bundle
INFO[0000] Found annotations file                        bundle-dir=bundle container-tool=docker
INFO[0000] Could not find optional dependencies file     bundle-dir=bundle container-tool=docker
INFO[0000] All validation tests have completed successfully 
# on make bundle config/manager/kustomization.yaml includes changes, which should be ignored for the below check
go test -race ./...
?   	github.com/open-telemetry/opentelemetry-operator	[no test files]
?   	github.com/open-telemetry/opentelemetry-operator/api/v1alpha1	[no test files]
ok  	github.com/open-telemetry/opentelemetry-operator/controllers	6.867s
ok  	github.com/open-telemetry/opentelemetry-operator/internal/config	0.179s
ok  	github.com/open-telemetry/opentelemetry-operator/internal/podinjector	7.221s
ok  	github.com/open-telemetry/opentelemetry-operator/internal/version	0.028s
ok  	github.com/open-telemetry/opentelemetry-operator/pkg/autodetect	0.087s
ok  	github.com/open-telemetry/opentelemetry-operator/pkg/collector	0.105s
ok  	github.com/open-telemetry/opentelemetry-operator/pkg/collector/adapters	0.054s
--- FAIL: TestOTLPExposeDefaultPorts (0.00s)
    receiver_otlp_test.go:97: 
        	Error Trace:	receiver_otlp_test.go:97
        	Error:      	"[{otlp-grpc  %!s(*string=<nil>) %!s(int32=4317) {%!s(intstr.Type=0) %!s(int32=4317) } %!s(int32=0)} {otlp-http  %!s(*string=<nil>) %!s(int32=4318) {%!s(intstr.Type=0) %!s(int32=4318) } %!s(int32=0)} {otlp-http-legacy  %!s(*string=<nil>) %!s(int32=55681) {%!s(intstr.Type=0) %!s(int32=4318) } %!s(int32=0)}]" should have 1 item(s), but has 3
        	Test:       	TestOTLPExposeDefaultPorts
    receiver_otlp_test.go:103: 
        	Error Trace:	receiver_otlp_test.go:103
        	Error:      	Not equal: 
        	            	expected: 0
        	            	actual  : 4318
        	Test:       	TestOTLPExposeDefaultPorts
FAIL
FAIL	github.com/open-telemetry/opentelemetry-operator/pkg/collector/parser	0.045s
ok  	github.com/open-telemetry/opentelemetry-operator/pkg/collector/reconcile	7.928s
ok  	github.com/open-telemetry/opentelemetry-operator/pkg/collector/upgrade	6.653s
?   	github.com/open-telemetry/opentelemetry-operator/pkg/naming	[no test files]
?   	github.com/open-telemetry/opentelemetry-operator/pkg/platform	[no test files]
ok  	github.com/open-telemetry/opentelemetry-operator/pkg/sidecar	0.085s
FAIL
make: *** [Makefile:60: test] Error 1

[jpkrohling]

I found the issue you are facing: you can reproduce it by running make kustomize. The workaround is to manually install kustomize, instead of letting the Makefile install it for you.

[joaopgrassi]

I found the issue you are facing: you can reproduce it by running make kustomize. The workaround is to manually install kustomize, instead of letting the Makefile install it for you.

Nice, thanks @jpkrohling ! I'll fix the tests later today and publish the PR.

Pull request has been modified.