Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add automatic RBAC creation for k8sobjects receiver #3430

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add automatic RBAC creation for k8sobjects receiver #3430

wants to merge 2 commits into from

Conversation

iblancasa
Copy link
Contributor

@iblancasa iblancasa commented Nov 6, 2024 •
edited
Loading

@iblancasa
Add automatic RBAC creation for k8sobjects receiver
6bf7d73 
Signed-off-by: Israel Blancas <iblancas@redhat.com>
@iblancasa iblancasa marked this pull request as ready for review November 11, 2024 08:41
@iblancasa iblancasa requested a review from a team as a code owner November 11, 2024 08:41
swiatekm
swiatekm approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nitpick about a comment.

internal/components/receivers/k8sobjects.go Outdated Show resolved Hide resolved
@iblancasa
Fix documentation
66d3b52 
Signed-off-by: Israel Blancas <iblancas@redhat.com>
pavolloffay
pavolloffay reviewed Nov 12, 2024
View reviewed changes
tests/e2e-automatic-rbac/receiver-k8sobjects/01-assert.yaml
@@ -0,0 +1,31 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine now, but it would be better to do a real e2e tests and asserting the k8sobjects actually can collect data

pavolloffay
pavolloffay reviewed Nov 12, 2024
View reviewed changes
tests/e2e-automatic-rbac/receiver-k8sobjects/01-install.yaml
@@ -0,0 +1,22 @@
apiVersion: opentelemetry.io/v1alpha1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we start using v1beta1 in tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavolloffay pavolloffay pavolloffay approved these changes

@swiatekm swiatekm swiatekm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add automatic RBAC creation for k8sobjects receiver
3 participants
@iblancasa @pavolloffay @swiatekm