Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable multi instrumentation by default #3302

Merged
merged 13 commits into from
Oct 1, 2024
Merged

Enable multi instrumentation by default #3302

merged 13 commits into from
Oct 1, 2024

Conversation

iblancasa
Copy link
Contributor

Closes #3090

@iblancasa
Enable multi instrumentation by default
4804180 
Signed-off-by: Israel Blancas <iblancas@redhat.com>
@iblancasa iblancasa requested a review from a team as a code owner September 23, 2024 10:35
@IshwarKanse IshwarKanse mentioned this pull request Sep 23, 2024
Closed
@jaronoff97
Copy link
Contributor

should we add some warnings as we discussed here?

@iblancasa
Copy link
Contributor Author

should we add some warnings as we discussed here?

I don't think so since #3213 was implemented. With this, the warnings are not needed because users will not need to do anything.

@iblancasa
Improve release notes
27b380e 
Signed-off-by: Israel Blancas <iblancas@redhat.com>
@iblancasa
Copy link
Contributor Author

Can we merge this?

@swiatekm
Copy link
Contributor

@jaronoff97 @pavolloffay can you have a look as well? I don't want to merge a change like this without at least another maintainer approval.

jaronoff97
jaronoff97 approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@jaronoff97 jaronoff97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this LGTM. i don't believe there's anything here where an existing user would be functionally broken though right? Just more possible error states where users try to do both methods?

@jaronoff97
Copy link
Contributor

also, looks like tests are failing

@iblancasa
Copy link
Contributor Author

I think this LGTM. i don't believe there's anything here where an existing user would be functionally broken though right?

I don't think so.

Just more possible error states where users try to do both methods?

Yes. And that should not be happening right now so..

also, looks like tests are failing

Yes. It is related to #3307.

@swiatekm swiatekm merged commit 218ff4a into open-telemetry:main Oct 1, 2024
33 checks passed
@iblancasa iblancasa deleted the feat/3090 branch October 1, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiatekm swiatekm swiatekm approved these changes

@frzifus frzifus frzifus approved these changes

@IshwarKanse IshwarKanse IshwarKanse approved these changes

@jaronoff97 jaronoff97 jaronoff97 approved these changes

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable "enable-multi-instrumentation" flag by default
5 participants
@iblancasa @jaronoff97 @swiatekm @IshwarKanse @frzifus